Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning of '8' and '4' #13

Closed
phellonchen opened this issue Apr 16, 2024 · 2 comments
Closed

Meaning of '8' and '4' #13

phellonchen opened this issue Apr 16, 2024 · 2 comments

Comments

@phellonchen
Copy link

phellonchen commented Apr 16, 2024

                    for j in range(8):
                        cur_image_features = image_features[cur_image_idx+j*4]
                        cur_new_input_embeds.append(cur_image_features)
                        cur_new_labels.append(torch.full((cur_image_features.shape[0],), IGNORE_INDEX, device=cur_labels.device, dtype=cur_labels.dtype))

what is the meaning of '8' and '4'?

@zyddnys
Copy link

zyddnys commented May 4, 2024

i got the same issue, if there's only one input image i then image_features shape is [8, 64, 5120], so cur_image_idx+j*4 will lead to out of bound

@guozonghao96
Copy link
Collaborator

Our repository has been fully improved, and almost all bugs have been eliminated. For details, please refer to the main branch and the LLaVA-UHD v1 branch. This issue is now closed. If there are any new problems, feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants