You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As this is a performance issue, it's really difficult to reproduce this outside of our repo as you need a large amount of source files and tests to see the problem.
Expected behavior
Performance does not change between versions
Actual behavior
After upgrading from 14.1.1 to 14.4.1 we noticed a massive performance hit in our unit test times, where everything got more than twice as slow.
We managed to track down the source of the slow performance to these commits:
31e78b1 (this makes our tests take 2.5x times as long)
ad7a297 (after locally reverting the previous commit, this makes our tests take ~20% longer, presumably due to the overhead of creating multiple typescript programs instead of 1 as we were before)
Once we reverted both of these commits locally, our test times returned to what they were on the previous version.
As these commits were just refactors, would it be possible to just revert these 2 commits and restore the previous performance? The only test that fails when I did this locally, was this one but I don't think we need to access the type at runtime as we are using an injection token, so I think it's fine for that to be compiled to undefined.
Additional context
We are using the isolatedModules: true flag in our jest config to disable type-checking
Version
14.4.1
Steps to reproduce
As this is a performance issue, it's really difficult to reproduce this outside of our repo as you need a large amount of source files and tests to see the problem.
Expected behavior
Performance does not change between versions
Actual behavior
After upgrading from
14.1.1
to14.4.1
we noticed a massive performance hit in our unit test times, where everything got more than twice as slow.We managed to track down the source of the slow performance to these commits:
Once we reverted both of these commits locally, our test times returned to what they were on the previous version.
As these commits were just refactors, would it be possible to just revert these 2 commits and restore the previous performance? The only test that fails when I did this locally, was this one but I don't think we need to access the type at runtime as we are using an injection token, so I think it's fine for that to be compiled to
undefined
.Additional context
We are using the
isolatedModules: true
flag in our jest config to disable type-checkingEnvironment
The text was updated successfully, but these errors were encountered: