Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigint orderId problem #335

Closed
wants to merge 2 commits into from
Closed

Conversation

berkaltiok
Copy link

Summary

In UsdM transactions, when buying ETH and a few other coins, the orderId comes as a bigint and the raw version is not accessible. For this reason, getOrder and similar operations that may require orderId cannot get results.
By including the json-bigint package in the axios process, all data from bigint is now intact.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +1 sidorares

@berkaltiok berkaltiok closed this Jun 5, 2023
@tiagosiebler
Copy link
Owner

Hey, sorry for the delay in reviewing this. Since this is (afaik) only a problem for one symbol, with known workarounds, I'm wondering about ways to address this without forcing a new (albeit valid but limited-use) dependency...

@berkaltiok
Copy link
Author

Hey, sorry for the delay in reviewing this. Since this is (afaik) only a problem for one symbol, with known workarounds, I'm wondering about ways to address this without forcing a new (albeit valid but limited-use) dependency...

Thank you for your return. I've done some research and there seems to be no way to solve it without dependency. I found another solution on Binance developer forums. Instead of using orderId, it says to use clientOrderId. In some cases orderId is not working properly. clientOrderId is returned as a string, it works fine.

@tiagosiebler
Copy link
Owner

Yes, that's the common workaround to this - inject your own custom order ID instead of using the exchange-provided one:
#208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants