Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap files repository #129

Open
alfredomtx opened this issue Feb 10, 2021 · 2 comments
Open

Minimap files repository #129

alfredomtx opened this issue Feb 10, 2021 · 2 comments

Comments

@alfredomtx
Copy link

alfredomtx commented Feb 10, 2021

Hello,

Where is the repository with the minimap .png Color and Cost files?

I'm asking because I would like to fork it and then make pull requests with the updated minimap files, what do you think of it?
It would make it easier to contribute to Tibia Map's project since it would be an easier way to send the updated files to you.

I think I saw the repository a while ago but I can't remember nor find it again 😅

Best regards,

@mathiasbynens
Copy link
Member

The minimap files are the generated output resulting from running the scripts on the source files in this repository. They are not part of the repository.

We could in theory change the source files to match the minimap files instead of the large "1 file per floor" approach we've been taking until now. It would make reviewing diffs for small changes easier, but it would make it harder to get a good overview for larger changes.

@alfredomtx
Copy link
Author

alfredomtx commented Feb 10, 2021

Humm got it! Well, if you think that would be viable I think it is a good idea in terms of contributing and keeping the minimap files updated, sending the updated 256x256 individually via pull request.

Anyway, that's up to you, I will continue contributing to the project in any way, be it opening issues manually or other ways.
Please let me know what you decide, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants