Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas consumption improvements #29

Open
drmathias opened this issue Jan 28, 2020 · 0 comments
Open

Gas consumption improvements #29

drmathias opened this issue Jan 28, 2020 · 0 comments
Labels
good first issue Good for newcomers
Milestone
V2

Comments

@drmathias
Copy link
Collaborator

Lots of good ideas for gas consumption improvements were suggested on stratisproject/CirrusSmartContracts#8. Key improvements:

  • Change Seat.Number data type to uint8 or uint16 (I'd lean towards using ushort, since byte could be too restrictive)
  • Accept ordered array of prices instead of tickets on BeginSale
  • Accept array index, instead of seat, on Reserve and ReleaseTicket

These changes could potentially roughly double the number of seats a contract could handle (and may be able to remove the arbitrary MAX_SEATS cap if constructor cost becomes greater than BeginSale cost).
@drmathias drmathias added the good first issue Good for newcomers label Jan 28, 2020
@drmathias drmathias added this to the V1.1 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
V2
Development

No branches or pull requests
1 participant
@drmathias