Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COASTAL-1461] Completion handler called twice with delay #78

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

nhamming
Copy link
Contributor

@nhamming nhamming commented Feb 24, 2025

https://tidepool.atlassian.net/browse/COASTAL-1461

Unfortunately, I'm not certain why the ASWebAuthenticationSession completion handler is being called twice. It seems to only occur when there is a network delay. The callback URL for the second call is as described in crashlytics:

... tried to resume its continuation more than once returning org.tidepool.tidepoolkit.auth://redirect?
error=temporarily_unavailable&error_description=authentication_expired&iss=https%3A%2F%2Fauth.qa2.tidepool.org
%2Frealms%2Fqa1!

This stops the crash, but obviously does not fix the root issue.

@nhamming nhamming requested review from ps2 and Camji55 February 24, 2025 07:47
@nhamming nhamming force-pushed the nate/bug/COASTAL-1461/completion-handler-called-twice branch 19 times, most recently from 7f476c2 to 3361d68 Compare February 24, 2025 19:34
@nhamming nhamming force-pushed the nate/bug/COASTAL-1461/completion-handler-called-twice branch 2 times, most recently from 0d6eb14 to 08ed641 Compare February 26, 2025 16:46
Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhamming nhamming force-pushed the nate/bug/COASTAL-1461/completion-handler-called-twice branch from 08ed641 to fb18c74 Compare February 27, 2025 11:18
@nhamming nhamming merged commit 4f4747f into dev Feb 27, 2025
1 check passed
@nhamming nhamming deleted the nate/bug/COASTAL-1461/completion-handler-called-twice branch February 27, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants