Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace java resizer with nodejs? #532

Open
m1ga opened this issue Aug 15, 2023 · 2 comments
Open

Replace java resizer with nodejs? #532

m1ga opened this issue Aug 15, 2023 · 2 comments

Comments

@m1ga
Copy link
Contributor

m1ga commented Aug 15, 2023

Currently the image resizing for the iOS icons/splashscreens is done by https://github.com/tidev/node-appc/tree/master/tools/resizer which is a java tool. Could it be that this is the only requirement for an iOS only build to have Java installed? Maybe it could be replaced by something like https://github.com/lovell/sharp (first google hit, not used it) in nodejs.

It is used in https://github.com/tidev/titanium-sdk/blob/master/iphone/cli/commands/_build.js#L6214

@ewanharris
Copy link
Contributor

I've always wondered if we could do this, I think we'd just have to be careful with it being a native module that the module works on all supported platforms and with how we distribute the SDK (there's no npm install on an end users machine so native modules can be difficult)

@m1ga
Copy link
Contributor Author

m1ga commented Aug 21, 2023

ah good point. Thats why java was a good choice 👍 Maybe it can be included in the titanium-cli as that is installed with npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants