Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_sql_render() doesn't pass three dots #1394

Closed
jarodmeng opened this issue Nov 6, 2023 · 1 comment · Fixed by #1428
Closed

db_sql_render() doesn't pass three dots #1394

jarodmeng opened this issue Nov 6, 2023 · 1 comment · Fixed by #1428
Labels
feature a feature request or enhancement

Comments

@jarodmeng
Copy link

I have a package RPresto that extends the db_sql_render() generic for Presto connections (code link). The extended db_sql_render() function has an added argument, use_presto_cte. The call stack goes from dbplyr::db_sql_render() to RPresto::db_sql_render.PrestoConnection(), so the passing of the use_presto_cte arg relies on the three dot ellipsis in dbplyr::db_sql_render(). However, in dbplyr 2.4.0, db_sql_render() doesn't pass on the ellipsis (see code link).

Happy to provide a quick PR to add the ellipsis passing to the function.

@hadley hadley changed the title db_sql_render() doesn't pass three dots ellipsis db_sql_render() doesn't pass three dots Nov 6, 2023
@hadley
Copy link
Member

hadley commented Nov 6, 2023

A PR would be great, thanks! (You might also want to consider using sql_options in your code).

@hadley hadley added the feature a feature request or enhancement label Dec 19, 2023
hadley added a commit that referenced this issue Dec 22, 2023
hadley added a commit that referenced this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants