Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export sql functions to create a new dbplyr backend outside of dbplyr? #1410

Open
eitsupi opened this issue Nov 17, 2023 · 1 comment
Open
Labels
feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Nov 17, 2023

I believe that currently if we create a new dbpryr backend outside of dbplyr, we will need to use non-exported functions.

For example in duckdb:
https://github.com/duckdb/duckdb-r/blob/7eeac781c7e524250f53b85bce8024fa01ad24c6/R/backend-dbplyr__duckdb_connection.R#L84-L99

Is there any reason not to export these functions?

@hadley hadley added feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL labels Dec 19, 2023
@hadley
Copy link
Member

hadley commented Dec 19, 2023

Just because they require a little more thought about their interface. But I think it's worth doing, and I'll try tackle early next year as part of a bigger push to standardise string and date handling across backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL
Projects
None yet
Development

No branches or pull requests

2 participants