Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch methods to default, not DBIConnection #1467

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Switch methods to default, not DBIConnection #1467

merged 1 commit into from
Feb 28, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Feb 26, 2024

This makes dbplyr work with pool, and I think it's the right decision as these methods are primarily wrappers around DBI methods, so we should fall back to its defaults.

Closes #1453

This makes dbplyr work with pool, and I think it's the right decision as these methods are primarily wrappers around DBI methods, so we should fall back to its defaults.
@hadley
Copy link
Member Author

hadley commented Feb 26, 2024

@mgirlich once you've had a chance to review these last 3 PRs, I'll start the release process.

@hadley hadley merged commit cce7c00 into main Feb 28, 2024
13 checks passed
@hadley hadley deleted the default-not-DBI branch February 28, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check table_path() approach with backends
2 participants