Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/change display isuzu #117

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

TakahikoHasegawa97
Copy link

Related Issue(required)

Description(required)

Display modification for more natural behavior

  • Adding new qml file system initialization
  • Chaing the display assignment from emergency to system init

Related PR(optional)

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

Copy link

@dkoldaev dkoldaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Was it the issue that we saw with emergency when disconnecting autoware?

@TakahikoHasegawa97
Copy link
Author

@dkoldaev yes thats the issue! It was always showing emergency when the autoware was disconnected

@TakahikoHasegawa97 TakahikoHasegawa97 merged commit ecd18e7 into erga_isuzu Aug 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants