Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove request library (#118) #119

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: remove request library (#118) #119

merged 1 commit into from
Sep 10, 2024

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Sep 10, 2024

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@tkhmy tkhmy requested a review from yabuta September 10, 2024 06:05
@tkhmy tkhmy merged commit 1dc4f13 into beta/v2.4.0 Sep 10, 2024
0 of 2 checks passed
@tkhmy tkhmy deleted the chore/update branch September 10, 2024 06:06
Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yabuta added a commit that referenced this pull request Sep 26, 2024
* cancel announce (#107)

* add fix going to depart and arrive announce (#108) (#111)

* add fix going to depart and arrive announce



* fix

* reset flag when no schedule

---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: Kah Hooi Tan <[email protected]>

* fix ignore emergency parameter not working (#110) (#112)

* fix ignore emergency parameter not working



* add comfortable stop condition



* change comfortable stop condition



---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: Kah Hooi Tan <[email protected]>

* add thread handlering (#109) (#113)

* fix condition (#114)

* remove unneccess step (#115)

* feat: remove request library (#118) (#119)

Signed-off-by: tkhmy <[email protected]>

* add handling for force goal (#120)

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: Kah Hooi Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants