fix: handle the external signage when there is no connect #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tkhmy <[email protected]>
yabuta
requested changes
Mar 1, 2024
| self._external_signage_available = True | ||
| except: | ||
| self._external_signage_available = False | ||
|
|
There was a problem hiding this comment.
self.parser = packet_tools.Parser(self.bus)でself.busがないとエラーが出るので__init__の中をtryで囲ったほうがいいかもしれません
Signed-off-by: tkhmy <[email protected]>
tkhmy
added a commit
that referenced
this pull request
Jun 10, 2024
* sync develop (#94) (#95) * feat: add service for setting announce volume * add getter/setter for volume service * get_volume service to publisher * fix qos * fix updating system volume * store/restore volume * merge beta/v2.2.0 update (#83) * do not announce emergency when stop mode! (#81) * do not announce emergency when stop mode! * fix * fix --------- * add mute timeout for engage (#82) --------- * disconnect view * delete code * add heartbeat diag * change message * update package.xml * change topic (#87) * Revert "feature: MRMのトピックを変更" (#89) * feat: 音声のON/OFF切り替え機能を追加（to develop） (#91) * add sound on/off * delete debug message * fix * gfix * fix * add external signage handler (#93) * init * update * clean up * fix * fix * fix code --------- --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: Rin Iwai <[email protected]> Co-authored-by: Kah Hooi Tan <[email protected]> Co-authored-by: Rin Iwai <[email protected]> * fix: handle the external signage when there is no connect (#96) * update service for trigger external signage (#97) * update service for trigger external signage Signed-off-by: tkhmy <[email protected]> * fix new external node (#98) * fix launch and depend --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: yabuta <[email protected]> * add autoware_control check (#99) * add autoware_control check Signed-off-by: tkhmy <[email protected]> * update external signage logic Signed-off-by: tkhmy <[email protected]> --------- Signed-off-by: tkhmy <[email protected]> * add hardware id (#100) * hotfix: 切断判定のtimeout時間を10秒から2秒へ変更する (#101) * reduce disconnect time condition * fix --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: yabuta <[email protected]> Co-authored-by: Rin Iwai <[email protected]> Co-authored-by: Rin Iwai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(required)
Description(required)
Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.