Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update service for trigger external signage #97

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Mar 28, 2024

Related Issue(required)

Description(required)

  • Update service for trigger external signage

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@tkhmy tkhmy requested a review from yabuta March 28, 2024 06:02
@yabuta
Copy link
Collaborator

yabuta commented Mar 29, 2024

@tkhmy
ベンチで確認したところ遅延なく動いたのでこちらで良さそうかと思います
signageのlaunchでexternal signageも起動したほうが良さそうだったのでそちらだけ修正しました

Copy link
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkhmy tkhmy merged commit 2316a6f into beta/v2.3.0 Mar 29, 2024
0 of 2 checks passed
@tkhmy tkhmy deleted the fix/external_signage_action branch March 29, 2024 00:52
tkhmy added a commit that referenced this pull request Jun 10, 2024
* sync develop (#94) (#95)

* feat: add service for setting announce volume

* add getter/setter for volume service

* get_volume service to publisher

* fix qos

* fix updating system volume

* store/restore volume

* merge beta/v2.2.0 update (#83)

* do not announce emergency when stop mode! (#81)

* do not announce emergency when stop mode!



* fix



* fix



---------



* add mute timeout for engage (#82)



---------




* disconnect view

* delete code

* add heartbeat diag

* change message

* update package.xml

* change topic (#87)

* Revert "feature: MRMのトピックを変更" (#89)

* feat: 音声のON/OFF切り替え機能を追加(to develop) (#91)

* add sound on/off

* delete debug message

* fix

* gfix

* fix

* add external signage handler (#93)

* init



* update



* clean up



* fix



* fix



* fix code



---------




---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: Rin Iwai <[email protected]>
Co-authored-by: Kah Hooi Tan <[email protected]>
Co-authored-by: Rin Iwai <[email protected]>

* fix: handle the external signage when there is no connect (#96)

* update service for trigger external signage (#97)

* update service for trigger external signage

Signed-off-by: tkhmy <[email protected]>

* fix new external node (#98)

* fix launch and depend

---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: yabuta <[email protected]>

* add autoware_control check (#99)

* add autoware_control check

Signed-off-by: tkhmy <[email protected]>

* update external signage logic

Signed-off-by: tkhmy <[email protected]>

---------

Signed-off-by: tkhmy <[email protected]>

* add hardware id (#100)

* hotfix: 切断判定のtimeout時間を10秒から2秒へ変更する (#101)

* reduce disconnect time condition

* fix

---------

Signed-off-by: tkhmy <[email protected]>
Co-authored-by: yabuta <[email protected]>
Co-authored-by: Rin Iwai <[email protected]>
Co-authored-by: Rin Iwai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants