From 4453119410969431a5d67e7ecb64cb02cbda9891 Mon Sep 17 00:00:00 2001 From: Kenzo Lobos-Tsunekawa Date: Mon, 25 Nov 2024 11:19:54 +0900 Subject: [PATCH 1/3] fix: removed unnecessary dependencies Signed-off-by: Kenzo Lobos-Tsunekawa --- .../package.xml | 20 +------------------ .../src/ceres_camera_intrinsics_optimizer.cpp | 1 - 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml index 2c960333..b65d8d9c 100644 --- a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml +++ b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml @@ -4,7 +4,7 @@ ceres_intrinsic_camera_calibrator 0.0.1 The ceres_intrinsic_camera_calibrator package - Kenzo Lobos Tsunekawa + Kenzo Lobos-Tsunekawa BSD @@ -13,29 +13,11 @@ autoware_cmake - autoware_universe_utils - cv_bridge eigen - geometry_msgs - image_geometry - image_transport - libboost-filesystem - libboost-serialization libceres-dev libgoogle-glog-dev - lidartag_msgs pybind11-dev rclcpp - sensor_msgs - std_msgs - std_srvs - tf2 - tf2_eigen - tf2_geometry_msgs - tf2_ros - tier4_calibration_msgs - tier4_tag_utils - visualization_msgs diff --git a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/src/ceres_camera_intrinsics_optimizer.cpp b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/src/ceres_camera_intrinsics_optimizer.cpp index 673211a2..f332da6d 100644 --- a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/src/ceres_camera_intrinsics_optimizer.cpp +++ b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/src/ceres_camera_intrinsics_optimizer.cpp @@ -26,7 +26,6 @@ #include #include -#include #include #include From 04ec6b04594e1cd3edf2e1fb9dc58fef124f9317 Mon Sep 17 00:00:00 2001 From: Kenzo Lobos-Tsunekawa Date: Fri, 20 Dec 2024 17:45:40 +0900 Subject: [PATCH 2/3] chore: we actually needed opencv Signed-off-by: Kenzo Lobos-Tsunekawa --- .../ceres_intrinsic_camera_calibrator/package.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml index b65d8d9c..fa851bc1 100644 --- a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml +++ b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/package.xml @@ -13,6 +13,7 @@ autoware_cmake + cv_bridge eigen libceres-dev libgoogle-glog-dev From 49b4ce528ae4b9592d9cfc611f0a1995c9f8e858 Mon Sep 17 00:00:00 2001 From: Kenzo Lobos-Tsunekawa Date: Mon, 23 Dec 2024 15:12:34 +0900 Subject: [PATCH 3/3] fix: deleted boost from the cmakelist Signed-off-by: Kenzo Lobos-Tsunekawa --- .../ceres_intrinsic_camera_calibrator/CMakeLists.txt | 5 ----- 1 file changed, 5 deletions(-) diff --git a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/CMakeLists.txt b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/CMakeLists.txt index d6296082..21bb0cec 100644 --- a/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/CMakeLists.txt +++ b/calibrators/intrinsic_camera_calibrator/ceres_intrinsic_camera_calibrator/CMakeLists.txt @@ -16,16 +16,12 @@ find_package(pybind11 REQUIRED) autoware_package() -# These need to be called after autoware_package to avoid being overwritten -find_package(Boost REQUIRED COMPONENTS system serialization filesystem) - # Optimizer as a library ament_auto_add_library(${PROJECT_NAME} SHARED src/ceres_camera_intrinsics_optimizer.cpp ) target_link_libraries(${PROJECT_NAME} - ${Boost_LIBRARIES} ${OpenCV_LIBS} ${CERES_LIBRARIES} ) @@ -47,7 +43,6 @@ ament_auto_add_executable(${PROJECT_NAME}_test ) target_link_libraries(${PROJECT_NAME}_test - ${Boost_LIBRARIES} ${OpenCV_LIBS} ${CERES_LIBRARIES} ${PROJECT_NAME}