Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pre-commit pass, make pre-commit mandatory #161

Open
mojomex opened this issue Jun 7, 2024 · 0 comments
Open

Make pre-commit pass, make pre-commit mandatory #161

mojomex opened this issue Jun 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mojomex
Copy link
Collaborator

mojomex commented Jun 7, 2024

Currently, pre-commit is not passing due to many (many) code style violations and clang-tidy warnings.
To be able to introduce mandatory coding guidelines for Nebula, first, pre-commit has to pass on the current codebase.
Once it passes, it should be made mandatory for all contributors.

@mojomex mojomex self-assigned this Jun 7, 2024
@mojomex mojomex added the enhancement New feature or request label Jun 7, 2024
@mojomex mojomex removed their assignment Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant