Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/record only mode #1

Open
wants to merge 1 commit into
base: aeva_seyond
Choose a base branch
from
Open

feat/record only mode #1

wants to merge 1 commit into from

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Dec 13, 2024

PR Type

  • New Feature

Related Links

Description

Adds a new parameter to Seyond sensors: publish_pointcloud.
When this is set to true, the pointcloud is published. When set to false, packets are published to nebula_packets but no decoding is performed. This reduces CPU load significantly.

Review Procedure

Launch with the following combinations and test operation:

Normal mode: connected to sensor, nebula_points should be viewable in rviz, nebula_packets is present
ros2 launch nebula_ros seyond_launch_all_hw.xml host_ip:=172.168.1.1 sensor_ip:=172.168.1.10 sensor_model:=Falcon data_port:=8010 publish_pointcloud:=true launch_hw:=true

Record only mode mode: connected to sensor, nebula_points is not published, nebula_packets is present
ros2 launch nebula_ros seyond_launch_all_hw.xml host_ip:=172.168.1.1 sensor_ip:=172.168.1.10 sensor_model:=Falcon data_port:=8010 publish_pointcloud:=false launch_hw:=true

Replay mode: not connected to sensor, nebula_packets is provided by a rosbag replay, and nebula_points is published
ros2 launch nebula_ros seyond_launch_all_hw.xml host_ip:=172.168.1.1 sensor_ip:=172.168.1.10 sensor_model:=Falcon data_port:=8010 publish_pointcloud:=true launch_hw:=false

(The nonsense mode of publish_pointcloud:=false launch_hw:=false is also available but results in no pointcloud)

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz requested a review from manato December 13, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant