Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Adds a new parameter to Seyond sensors:
publish_pointcloud
.When this is set to
true
, the pointcloud is published. When set tofalse
, packets are published tonebula_packets
but no decoding is performed. This reduces CPU load significantly.Review Procedure
Launch with the following combinations and test operation:
Normal mode: connected to sensor,
nebula_points
should be viewable in rviz,nebula_packets
is presentros2 launch nebula_ros seyond_launch_all_hw.xml host_ip:=172.168.1.1 sensor_ip:=172.168.1.10 sensor_model:=Falcon data_port:=8010 publish_pointcloud:=true launch_hw:=true
Record only mode mode: connected to sensor,
nebula_points
is not published,nebula_packets
is presentros2 launch nebula_ros seyond_launch_all_hw.xml host_ip:=172.168.1.1 sensor_ip:=172.168.1.10 sensor_model:=Falcon data_port:=8010 publish_pointcloud:=false launch_hw:=true
Replay mode: not connected to sensor,
nebula_packets
is provided by a rosbag replay, andnebula_points
is publishedros2 launch nebula_ros seyond_launch_all_hw.xml host_ip:=172.168.1.1 sensor_ip:=172.168.1.10 sensor_model:=Falcon data_port:=8010 publish_pointcloud:=true launch_hw:=false
(The nonsense mode of
publish_pointcloud:=false launch_hw:=false
is also available but results in no pointcloud)Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks