Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete implementation of math::geometry::getClosestPoses function #1332

Closed
HansRobo opened this issue Jul 31, 2024 · 0 comments · Fixed by #1475
Closed

Incomplete implementation of math::geometry::getClosestPoses function #1332

HansRobo opened this issue Jul 31, 2024 · 0 comments · Fixed by #1475
Assignees
Labels
bug Something isn't working

Comments

@HansRobo
Copy link
Member

Describe the bug

https://github.com/tier4/scenario_simulator_v2/blob/master/common/math/geometry/src/bounding_box.cpp#L58

math::geometry::getClosestPoses function does not calculate closest poses in case where the shortest point is a point that is not a vertex of bbox1.

In the current implementation, the function returns the shortest distance between each edge of bbox0 and each vertex of bbox1.
But this is imcomplete.

Additionally, this function has multiple function calls to boost::geometry::intersects and boost::geometry::disjoint, but there doesn't seem to be worth calling these multiple times.

Expected behavior
math::geometry::getClosestPoses function does calculate closest poses in all cases include cases where the shortest point is a point that is not a vertex of bbox1.

Desktop (please complete the following information):

  • Ubuntu Version: 22.04
  • ROS 2 version: Humble
  • DDS: Cyclone DDS
@HansRobo HansRobo added the bug Something isn't working label Jul 31, 2024
@yamacir-kit yamacir-kit self-assigned this Sep 27, 2024
@HansRobo HansRobo assigned f0reachARR and unassigned yamacir-kit Nov 28, 2024
@HansRobo HansRobo linked a pull request Dec 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants