Skip to content
This repository has been archived by the owner on Mar 8, 2019. It is now read-only.

Removing 'Heya!' console.log message #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndrewRayCode
Copy link

It's tacky. Addresses issue #332

It's tacky. Addresses issue tiff#332
@robotslave
Copy link

Unless the developers' position has changed, you'll need to just use a fork: see issue 209.

@sergeyklay
Copy link

if (DEBUG)
{
   ...
}

@reustle
Copy link

reustle commented May 18, 2013

He's not going to pull this. Seeing that a) there are 28 open pull requests, b) there are 169 open issues and c) he won't remove this tacky message, I think it's time for a fresh new html5 wysiwyg project.

@sergeyklay
Copy link

@reustle It seems you are too categorical :)

@robotslave
Copy link

I'm not sure he's being too categorical, given that it's been 5 months since the last commit, and a full year year since the release of 0.3.0.

Sadly, this is looking more and more like an abandoned project.

@sergeyklay
Copy link

@robotslave What's stopping you to fork it?

@AndrewRayCode
Copy link
Author

There are 600+ forks. We need an official ownership transfer

@robotslave
Copy link

The team I work with has in fact already forked it to correct some of the many issues that haven't been addressed. We've made a few pull requests, that have been closed or ignored.

The fact remains that this project increasingly appears to be abandoned.

@AndrewRayCode
Copy link
Author

An ideal solution is to rename the project to something new and outshine the old one and become the new hotness.

@robotslave
Copy link

And also, put a bell on that cat...

@molily
Copy link

molily commented May 24, 2013

@robotslave Is your team’s fork available on Github?

@robotslave
Copy link

Unfortunately, no. But the stuff we've added/fixed that isn't coupled to our app/platform (or to jQuery) can all be cribbed from one pull request or another to wysihtml5.

If we were to scrap what we've got now and start over (and we won't do that any time soon), we'd begin by looking for a close-enough-to-requirements editor-widget that's been designed and built on top of jQuery from the start. Lessons learned and all that.

@zackd
Copy link

zackd commented Jun 14, 2013

+1 is just annoying

@AndrewRayCode
Copy link
Author

Hey @xing. Ping. What are you up to buddy?

@nikhgupta
Copy link

I guess, we can disable the console.log just before loading this plugin, and re-enable it later:

var logger = console.log;
console.log = function() {};
$(".wysihtml5").wysihtml5();
console.log = logger;

Am I correct? Is there any unwanted side-effect to this?

At least, this rids me of those verbose test suites, I had ;)

@philfreo
Copy link

philfreo commented Jun 4, 2014

Is there anyone with an active fork of this project that is happy to keep maintaining it?

@filipegiusti
Copy link

@philfreo weird timing, I'm looking for an active fork right now. If you find let me know.

@Waxolunist
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants