-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve certificate management #3727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rene-dekker
commented
Jan 29, 2025
•
edited
Loading
edited
- Rotate certificates 1 month before expiry (if issued by operator) to minimize potential for down time. (Currently certificates are valid for 825 days.)
- If a certificate is expired, a controller that is fetching a cert for the purpose of adding it to a trusted bundle will skip it. This is similar to the behaviour if a certificate does not exist at all.
- If a certificate is expired, a controller that is responsible for creating it will replace it. (This is already the current behaviour, just mentioning it here for completeness.)
- Improve the test suite, such that cert creation for some certs is done once, and not BeforeEach, cutting down run time of the suite from 40s -> 10s.
9911e9d
to
0eb7554
Compare
Brian-McM
reviewed
Feb 1, 2025
- Rotate certificates 1 month before expiry (if issued by operator) to minimize potential for down time. - If a certificate is expired, a controller that is fetching a cert for the purpose of adding it to a trusted bundle will skip it. This is similar to the behaviour if a certificate does not exist at all.
Brian-McM
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
Brian-McM
added a commit
that referenced
this pull request
Feb 7, 2025
…727-origin-release-v1.37 Automated cherry pick of #3727: Fix dead-lock between degraded controllers due to
Brian-McM
added a commit
that referenced
this pull request
Feb 7, 2025
…727-origin-release-v1.36 Automated cherry pick of #3727: Fix dead-lock between degraded controllers due to
marvin-tigera
added a commit
that referenced
this pull request
Feb 10, 2025
…727-origin-release-v1.34 Automated cherry pick of #3727: Fix dead-lock between degraded controllers due to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.