Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootloader patches #320

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Bootloader patches #320

merged 4 commits into from
Dec 2, 2024

Conversation

eenurkka
Copy link

Add 2 patches for the bootloader

@eenurkka
risc-v/mpfs: introduce CONFIG_MPFS_CLKINIT flag
05ae6f0 
This CONFIG_MPFS_CLKINIT is set with bootloaders by default. However,
this gives an option to have it unset. In some cases, the clocks
may be already set so it becomes unnecessary to re-initialize them.

Signed-off-by: Eero Nurkkala <[email protected]>
@eenurkka
risc-v/mpfs: clear IPIs at boot
9586542 
Inter-processor interrupts (IPIs) are not cleared via mie/mip registers but
rather, at the MPFS_CLINT_BASE + mhartid * 4 (a word or 4-byte offset for
each hart).

If there's an IPI waiting, the system will continue to boot altough it's
expected to stay at the wfi loop waiting for the IPI.

Signed-off-by: Eero Nurkkala <[email protected]>
@eenurkka eenurkka requested review from jlaitine and pussuw November 29, 2024 11:02
@eenurkka
risc-v/mpfs: mpfs_timerisr: add missing header file
971afc9 
Add the header.

Signed-off-by: Eero Nurkkala <[email protected]>
@pussuw
Copy link

pussuw commented Dec 2, 2024

Seems like NuttX size has increased so much that the "standalone" target no longer fits:
riscv-none-elf-ld: /home/runner/work/nuttx/nuttx/sources/nuttx/nuttx section .text' will not fit in region envm'
riscv-none-elf-ld: region `envm' overflowed by 3312 bytes

Maybe just remove the target entirely ?

@pussuw
Copy link

pussuw commented Dec 2, 2024

The ARM build error is from upstream:
audio/wm8994.c: In function 'wm8994_audio_output':
Error: audio/wm8994.c:1898:3: error: implicit declaration of function 'up_mdelay' [-Werror=implicit-function-declaration]
1898 | up_mdelay(40);
| ^~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:109: wm8994.o] Error 1
make[1]: Target 'libdrivers.a' not remade because of errors.
make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
make: Target 'all' not remade because of errors.

@eenurkka
risc-v: mpfs: remove icicle/configs/standalone
f619d58 
This no longer fits the eNVM. Thus, remove it for now.

Signed-off-by: Eero Nurkkala <[email protected]>
@eenurkka
Copy link
Author

eenurkka commented Dec 2, 2024

Maybe just remove the target entirely ?
I was thinking the same

@eenurkka
Copy link
Author

eenurkka commented Dec 2, 2024

Maybe this is ok to merge?

@pussuw
Copy link

pussuw commented Dec 2, 2024

Merge away

@eenurkka eenurkka merged commit ab91130 into master Dec 2, 2024
9 of 10 checks passed
@pussuw pussuw deleted the bootloader-patches branch December 2, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaitine jlaitine jlaitine approved these changes

@pussuw pussuw pussuw approved these changes

Assignees
No one assigned
Labels
Arch: risc-v Board: risc-v Size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eenurkka @pussuw @jlaitine