Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated user homepages indicator includes any file #59

Open
litemotiv opened this issue Dec 7, 2024 · 0 comments · May be fixed by #60
Open

Updated user homepages indicator includes any file #59

litemotiv opened this issue Dec 7, 2024 · 0 comments · May be fixed by #60

Comments

@litemotiv
Copy link

Currently the updated user homepages indicator will test whether any files were updated in the user's public_html directory:

site/index.php

Lines 214 to 221 in d5f2563

// Check for any recent changes in the public_html directory
$recentChange = false;
foreach (glob("$user/public_html/*") as $file) {
if (filemtime($file) > $oneMonthAgo) {
$recentChange = true;
break;
}
}

A consequence of this is that users with automatic scripts that list things like 'online users' will always be shown as recently updated.

As an alternative, perhaps the glob could only test for index.{html,htm,php}, instead of any updated file in the user's public_html?
@litemotiv litemotiv linked a pull request Dec 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test only index pages for recent changes litemotiv/tilde.club_site
1 participant
@litemotiv