Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The amd build is broken with require.js, and conductor.js.html is not shimmable #101

Open
alexkalderimis opened this issue Apr 30, 2014 · 1 comment

Comments

@alexkalderimis
Copy link

It is great that you produce an amd build, but it is sadly broken since its modules are misordered (dependencies needing to be declared first). It also would require a lot of config to get it to work correctly since it has a lot undeclared dependencies (rsvp, kamino, etc etc). The js.html build includes these deps but is not shimmable with requirejs since it tests that define is absent and requireModule is also absent. Loading with require means that the first test fails, even though requireModule is not part of the require API.

I installed the current version of conductor (0.3.0) with bower.

@cyril-sf
Copy link
Contributor

cyril-sf commented May 1, 2014

Hi @alexkalderimis,

We have updated the loader ( ed2787f ) and removed the polyglot ( a1a2755 ) after the 0.3.0 release.

It seems fair for us to publish a new version of Conductor.js, but feel free to download the latest build from the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants