Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in feature: more aggressive link cleaning #550

Open
zentg1 opened this issue Dec 6, 2020 · 3 comments
Open

Opt-in feature: more aggressive link cleaning #550

zentg1 opened this issue Dec 6, 2020 · 3 comments

Comments

@zentg1
Copy link

zentg1 commented Dec 6, 2020

hey tim, it seemed to work at first when i clicked affiliate links and now its not working. Im seeing a /ref=as_li_ss_tl? in the url, what is that? - for example i got this link: https://www.amazon.com/Mitutoyo-Advanced-Absolute-Digital-Caliper/dp/B00WMKUUAQ/ref=as_li_ss_tl?ie=UTF8&linkCode=sl1&linkId=0ca01780457ac001751b779809516530&language=en_US Also for the first couple links i tested it with i got the notification that the tag was removed - not getting that notification anymore

@timbru31
Copy link
Owner

timbru31 commented Dec 6, 2020

The extension filters on the tag query parameter. Your link does not include one. It’s incredible difficult to find information what the different parameters do - any help appreciated.

@timbru31
Copy link
Owner

timbru31 commented Dec 7, 2020

What I could think of, as a new opt-in feature: Remove all query parameters and the /ref part if present. AFAIK URLs work if they contain the ASIN (i.e., B00WMKUUAQ in this case), so https://www.amazon.com/Mitutoyo-Advanced-Absolute-Digital-Caliper/dp/B00WMKUUAQ and even https://www.amazon.com/dp/B00WMKUUAQ

As I can't vouch that the extension does not remove any relevant information, this feature would be opt-in. ("aggressive mode" or something like that)

Still, AFAIK, only the tag parameter is relevant for the Affiliate program, every other parameter is used internally by Amazon (which sort of link, recommended product, etc.)

@zentg1
Copy link
Author

zentg1 commented Dec 9, 2020

Right on makes sense. Yeah ideally I'd like to just have the product url and nothing else like https://www.amazon.com/dp/B00WMKUUAQ, but you're right I see the /ref parameter often while just browsing my account and etc so it prolly best to make it an opt-in feature!

@timbru31 timbru31 changed the title don't think its working Opt-in feature: more aggressive link cleaning Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants