Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force pushes can screw up stored reminders #10

Open
timbussmann opened this issue Oct 29, 2020 · 0 comments
Open

Force pushes can screw up stored reminders #10

timbussmann opened this issue Oct 29, 2020 · 0 comments
Labels
question Further information is requested

Comments

@timbussmann
Copy link
Owner

As all reminders are stored in the database based on the commit history, if this commit history is changed (via force pushing a different history) this could cause inconsistencies with the reminder database.

e.g.

Original history:

  • Create reminder1
  • Create reminder2

-> reminder1 and reminder2 are stored in the database

Force pushed history:

  • Create reminder1

-> reminder1 will be updated/reapplied while reminder2 remains as originally defined in the database and will be continued to be opened but there is no way to delete the reminder other than recreating it with the same exact id and deleting it afterwards.

Not sure whether there might also be a case where the deletion of a reminder is being removed via a force push and therefore the reminder is again in the repository but not in the database. This depends on what commit information the force push contains as it could also potentially just recreate the reminder if it's listed in the commits.

I haven't encountered or tested such scenarios yet.

@timbussmann timbussmann added the question Further information is requested label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant