Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ComboBox] Change close button cursor from default to pointer #65

Open
navin-moorthy opened this issue May 15, 2020 · 4 comments
Open

[ComboBox] Change close button cursor from default to pointer #65

navin-moorthy opened this issue May 15, 2020 · 4 comments
Assignees
@navin-moorthy
Labels
Status: Assigned ➡ This issue has been assigned to a team member Topic: Design and UX ✍️ Type: Bug 🐛 Something isn't working

Comments

@navin-moorthy
Copy link
Collaborator

For pointer hover, cursor should be pointer for close button right ?

Orginally posted at issue
@navin-moorthy navin-moorthy added Topic: UX 🤳 Type: Bug 🐛 Something isn't working labels May 15, 2020
@navin-moorthy navin-moorthy self-assigned this May 15, 2020
@navin-moorthy navin-moorthy added the Status: Assigned ➡ This issue has been assigned to a team member label May 15, 2020
@navin-moorthy
Copy link
Collaborator Author

I got the inspiration from react-select, they don't change the cursor from default.
Personally I feel, this is good and feels like the whole component is one.
Planned to change the close button on Multi-Select Tag component to cursor: default
Let me know your views.

@navin-moorthy
Copy link
Collaborator Author

@prasanna1211 and @sandeepprabhakaran
Let me know your thoughts on this.
Hover over close button,

  1. cursor: default OR
  2. cursor: pointer

@prasanna1211
Copy link
Contributor

Again one such discussion: . For me pointer is fine personally.

@navin-moorthy
Copy link
Collaborator Author

Again one such discussion: . For me pointer is fine personally.

Okay, lets get a word from Sandeep aswell before changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navin-moorthy navin-moorthy

Labels
Status: Assigned ➡ This issue has been assigned to a team member Topic: Design and UX ✍️ Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prasanna1211 @navin-moorthy