From 97a4a756086405dc64f4257f375ba4a3fe8335a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B4natas=20Davi=20Paganini?= Date: Tue, 9 Apr 2024 16:33:18 -0300 Subject: [PATCH] Remove replication_factor references --- docs/command_line.md | 5 +---- spec/timescaledb/database/schema_statements_spec.rb | 11 +---------- spec/timescaledb/migration_helper_spec.rb | 1 - 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/docs/command_line.md b/docs/command_line.md index 10a847a..f36dd3b 100644 --- a/docs/command_line.md +++ b/docs/command_line.md @@ -97,8 +97,6 @@ Tick.hypertable num_chunks: 1, compression_enabled: false, is_distributed: false, - replication_factor: nil, - data_nodes: nil, tablespaces: nil> ``` @@ -119,8 +117,7 @@ unknown OID 2206: failed to recognize type of 'primary_dimension_type'. It will range_start_integer: nil, range_end_integer: nil, is_compressed: false, - chunk_tablespace: nil, - data_nodes: nil>] + chunk_tablespace: nil>] ``` > Chunks are created by partitioning the hypertable data into one diff --git a/spec/timescaledb/database/schema_statements_spec.rb b/spec/timescaledb/database/schema_statements_spec.rb index cb0c968..cbed066 100644 --- a/spec/timescaledb/database/schema_statements_spec.rb +++ b/spec/timescaledb/database/schema_statements_spec.rb @@ -40,14 +40,6 @@ end end - context 'when passing integer params' do - it 'returns expected SQL' do - expect( - described_class.create_hypertable_sql('events', 'created_at', replication_factor: 3) - ).to eq("SELECT create_hypertable('events', 'created_at', replication_factor => 3);") - end - end - context 'when passing string params' do it 'returns expected SQL' do optional_params = { @@ -67,7 +59,6 @@ it 'returns expected SQL' do optional_params = { if_not_exists: true, - replication_factor: 3, partitioning_column: 'category', number_partitions: 3, partitioning_func: 'category_func', @@ -76,7 +67,7 @@ expect( described_class.create_hypertable_sql('events', 'created_at', **optional_params) - ).to eq("SELECT create_hypertable('events', 'created_at', 'category', 3, if_not_exists => 'TRUE', replication_factor => 3, partitioning_func => 'category_func', distributed => 'FALSE');") + ).to eq("SELECT create_hypertable('events', 'created_at', 'category', 3, if_not_exists => 'TRUE', partitioning_func => 'category_func', distributed => 'FALSE');") end end end diff --git a/spec/timescaledb/migration_helper_spec.rb b/spec/timescaledb/migration_helper_spec.rb index bb52fae..d21aec9 100644 --- a/spec/timescaledb/migration_helper_spec.rb +++ b/spec/timescaledb/migration_helper_spec.rb @@ -50,7 +50,6 @@ "is_distributed" => false, "num_chunks" => 0, "num_dimensions" => 1, - "replication_factor" => nil, "tablespaces" => nil}) end end