Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to publish a non-existent package gives a confusing message #11

Open
i-e-b opened this issue Jul 18, 2016 · 0 comments
Open

Trying to publish a non-existent package gives a confusing message #11

i-e-b opened this issue Jul 18, 2016 · 0 comments

Comments

@i-e-b
Copy link
Collaborator

i-e-b commented Jul 18, 2016

Found when running a 'version remapper' through

    return workspace.workspacePackages({ additionalPaths: [ "./node_modules" ] })
        .pipe(workspace.filter(function (packageDescriptor, packagePath) {
            return packageDescriptor.name.startsWith(PACKAGE_PREFIX);
        }))
        .pipe(versionReMapper);

And the workspace packages contain references to a deleted package.

This results in the error message "Circular dependency found in Workspace: ..."
Coming from WorkspacePackages.ts::streamPackages (around line 135).

Looks like any failure in the callback is assumed to be a circular dependency.

Idea: Run the findPackageNames function, and only give the circular dependency message if there is a match. Otherwise give a generic message including the target file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant