Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hobby.porn and PornHub #36

Merged
merged 4 commits into from
Jun 29, 2024
Merged

Conversation

IAmKontrast
Copy link
Contributor

Added performer and scene support for hobby.porn which contains mostly information about pornhub videos even deleted ones.

This page unfortunately contains css properties like position, top, bottom, left and more for class .file so I've added position: inherit; otherwise the Path div superimpose the whole dialog. This shouldn't cause any issues on the other websites.

@IAmKontrast IAmKontrast changed the title Add support for hobby.porn Add support for hobby.porn and PornHub Jun 26, 2024
@IAmKontrast
Copy link
Contributor Author

Added support for PornHub for Scenes, Performers and Studios. Implementation should contain all three targets at all main, detail and search result pages.

@IAmKontrast IAmKontrast mentioned this pull request Jun 26, 2024
@timo95
Copy link
Owner

timo95 commented Jun 29, 2024

Thanks for your contribution.

I replaced your hidden elements workaround with a general solution. Tell me if it broke anything.

@timo95 timo95 merged commit 8760c42 into timo95:master Jun 29, 2024
1 check passed
@IAmKontrast
Copy link
Contributor Author

Thanks for merging and your workaround!

With replacing my removeHiddenElements you forgot to use the new functionality. #37 Should work the way we were thinking of.

I saw you updated the 1.1.0 in the changelog. For those who are no following your repository. You still have your version 1.0.0 tagged as the newest one. Check for update at https://github.com/timo95/stash-checker/releases/latest/download/index.prod.user.js still points on the old one even it shows 1.1.0.

@timo95
Copy link
Owner

timo95 commented Jun 30, 2024

Yes, I wanted to finish the custom graphql feature before releasing 1.1, but it might be better to move that to 1.2.

@IAmKontrast
Copy link
Contributor Author

I was just confused about the difference between the version number in the changelog file, the userscript and the GitHub release. Merging to the master branch, updating the changelog with the changes under "WIP" or "next features" and then updating the userscript version and creating a new GitHub release when you're actually releasing the next version would make more sense to me and is more in line with gitflow practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants