Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[standard-action-handler] API 응답 일반화 노출 기능을 추가합니다. #2947

Merged
merged 7 commits into from
Nov 9, 2023
Merged

[standard-action-handler] API 응답 일반화 노출 기능을 추가합니다. #2947

merged 7 commits into from
Nov 9, 2023

Conversation

zhsks528
Copy link
Contributor

@zhsks528 zhsks528 commented Oct 17, 2023 •
edited
Loading

PR 설명

API 호출 및 응답을 모달로 확인할 수 있는 기능을 추가합니다.
자세한 내용은 스펙 문서에서 확인하실 수 있습니다.

기존 fetch-api 기능과 차이점

fetch-api는 호출만 담당하지만 converse는 API 반환 값을 이용해 모달을 노출하는 기능까지 포함되어있습니다.

사용법

어드민에서 응답을 받고싶은 API endpoint를 입력합니다.

형식 : /web-action/converse?path={인코딩된 API endpoint}
예시 : /web-action/converse?path=%2Fapi%2Fbenefit%2Ftna-promotions%2Ffirst-buy

  • TNA 첫 구매 대상자 쿠폰 발급 API

변경 내역

API 응답 일반화 노출 기능을 추가합니다.

스크린샷 & URL

2023-10-24.10.16.43.mov

@zhsks528 zhsks528 self-assigned this Oct 17, 2023
@zhsks528
Copy link
Contributor Author

release-canary

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (3645261) 12.20% compared to head (1047d13) 12.16%.
Report is 60 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
- Coverage   12.20%   12.16%   -0.05%     
==========================================
  Files         685      686       +1     
  Lines       36134    36266     +132     
  Branches     8926     8961      +35     
==========================================
  Hits         4410     4410              
- Misses      31717    31849     +132     
  Partials        7        7
Files Coverage Δ
packages/standard-action-handler/src/index.ts 0.00% <ø> (ø)
packages/standard-action-handler/src/converse.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhsks528
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v13.7.1-pr-2947.2 has been published!

@zhsks528
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v13.7.1-pr-2947.3 has been published!

@zhsks528
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v13.7.1-pr-2947.4 has been published!

@zhsks528
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v13.7.1-pr-2947.5 has been published!

@zhsks528 zhsks528 changed the title Feat/converse action API 응답 일반화 노출 기능을 추가합니다. Oct 24, 2023
@zhsks528 zhsks528 marked this pull request as ready for review October 24, 2023 01:17
@zhsks528 zhsks528 requested a review from a team as a code owner October 24, 2023 01:17
@zhsks528 zhsks528 requested review from inbeom, choisohyun and torres-triple and removed request for a team October 24, 2023 01:17
@zhsks528 zhsks528 requested a review from drakang4 November 9, 2023 02:03
@zhsks528
Copy link
Contributor Author

zhsks528 commented Nov 9, 2023

release-canary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

v13.7.1-pr-2947.6 has been published!

zhsks528
zhsks528 commented Nov 9, 2023
View reviewed changes
.github/workflows/cd.yaml
@@ -46,7 +46,7 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}
registry-url: ${{ env.NPM_REGISTRY_URL }}
cache: 'pnpm'
# cache: 'pnpm'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/setup-node#801 이슈로 주석처리 했습니다.

@zhsks528 zhsks528 requested a review from a team November 9, 2023 05:48
@guswl98
Copy link
Contributor

guswl98 commented Nov 9, 2023

Readme에도 추가해주시면 좋을 것 같습니다~!

@guswl98
Copy link
Contributor

guswl98 commented Nov 9, 2023

기능 이름이 converse로 정해진 이유가 무엇일까요??

@zhsks528
Copy link
Contributor Author

zhsks528 commented Nov 9, 2023

기능 이름이 converse로 정해진 이유가 무엇일까요??

API를 호출하고 반환된 응답을 화면에 보여주는 동작이 해당 기능의 주 목적입니다.
동작 관점에서 봤을 때, 대화하는 것과 유사해보여 converse로 정의했습니다. w/ 이욜

아래의 단어들로 정의하기에는 너무 기능에 초점이 맞춰져있는 것 같아서 제외했습니다.

  • modal / dialog ...

더 좋은 함수명이 있다면 제안 부탁드립니다 🙇‍♂️ @guswl98

@zhsks528 zhsks528 added this to the v13.11.0 milestone Nov 9, 2023
@zhsks528 zhsks528 merged commit c063700 into main Nov 9, 2023
11 checks passed
@zhsks528 zhsks528 deleted the feat/converse-action branch November 9, 2023 08:12
@guswl98
Copy link
Contributor

guswl98 commented Nov 9, 2023

아 대화하다의 converse였군요! 반대라는 의미만 떠올렸네요.... 😅

@zhsks528 zhsks528 changed the title API 응답 일반화 노출 기능을 추가합니다. [standard-action-handler] API 응답 일반화 노출 기능을 추가합니다. Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dia-triple dia-triple dia-triple approved these changes

@guswl98 guswl98 guswl98 approved these changes

@dongoc dongoc dongoc approved these changes

@inbeom inbeom Awaiting requested review from inbeom inbeom is a code owner automatically assigned from titicacadev/frontend

@choisohyun choisohyun Awaiting requested review from choisohyun choisohyun is a code owner automatically assigned from titicacadev/frontend

@torres-triple torres-triple Awaiting requested review from torres-triple torres-triple is a code owner automatically assigned from titicacadev/frontend

@drakang4 drakang4 Awaiting requested review from drakang4

Assignees

@zhsks528 zhsks528

Labels
standard-action-handler
Projects
None yet
Milestone
v13.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zhsks528 @guswl98 @dongoc @dia-triple