[chat] beforeSentMessages 초기 props만 저장하도록 수정 #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
release-canary |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2969 +/- ##
==========================================
- Coverage 12.17% 12.17% -0.01%
==========================================
Files 687 687
Lines 36212 36213 +1
Branches 8941 8943 +2
==========================================
Hits 4410 4410
- Misses 31795 31796 +1
Partials 7 7
☔ View full report in Codecov by Sentry. |
|
v13.8.2-pr-2969.3 has been published! |
choisohyun
changed the title
choisohyun
requested review from
zzolain,
zhsks528 and
torres-triple
and removed request for
a team
dongoc
approved these changes
Oct 31, 2023
zhsks528
approved these changes
Oct 31, 2023
dia-triple
reviewed
Oct 31, 2023
| message: beforeSentMessages, | ||
| }) | ||
| }, [beforeSentMessages]) | ||
| initBeforeSentMessages && |
There was a problem hiding this comment.
initBeforeSentMessages의 default값이 []이기 때문에 항상 이 구문은 참일 것 같아요!
There was a problem hiding this comment.
#2975
요기서 수정했습니다!!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
변경 내역
체크리스트
스크린샷 & URL