Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat] Message에 sender 정보를 포함하는 api 변경에 대응합니다. #2973

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Oct 31, 2023

PR 설명

[Chat] Message에 sender 정보를 포함하는 api 변경에 대응합니다.

  • userInfo를 제거하고 각 message에 sender 정보가 포함되도록 수정합니다. (행사챗에서 사용자수가 1000명이 넘어가니 감당이 안되는군요😂)
  • userInfo 대신 유저의 정보(me)를 받도록 수정합니다.

@dongoc dongoc added the chat label Oct 31, 2023
@dongoc dongoc self-assigned this Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (26b22e9) 12.14% compared to head (4baba7b) 12.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   12.14%   12.14%           
=======================================
  Files         689      689           
  Lines       36314    36308    -6     
  Branches     8961     8958    -3     
=======================================
  Hits         4410     4410           
+ Misses      31897    31891    -6     
  Partials        7        7           
Files Coverage Δ
packages/chat/src/types/index.ts 0.00% <ø> (ø)
packages/chat/src/chat-bubble/chat-bubble.tsx 0.00% <0.00%> (ø)
packages/chat/src/chat/chat.tsx 0.00% <0.00%> (ø)
packages/chat/src/utils/constants.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc
Copy link
Contributor Author

dongoc commented Oct 31, 2023

release-canary

@github-actions
Copy link

v13.8.2-pr-2973.6 has been published!

@dongoc dongoc added this to the v13.8.2 milestone Oct 31, 2023
@dongoc dongoc modified the milestones: v13.8.2, v13.9.1 Oct 31, 2023
@dongoc
Copy link
Contributor Author

dongoc commented Nov 1, 2023

release-canary

Copy link

github-actions bot commented Nov 1, 2023

v13.8.2-pr-2973.14 has been published!

@dongoc
Copy link
Contributor Author

dongoc commented Nov 3, 2023

release-canary

Copy link

github-actions bot commented Nov 3, 2023

v13.8.2-pr-2973.15 has been published!

@dongoc dongoc marked this pull request as ready for review November 3, 2023 05:55
@dongoc dongoc requested a review from a team as a code owner November 3, 2023 05:55
@dongoc dongoc requested review from kooinsung, sohnjunior, guswl98 and choisohyun and removed request for a team November 3, 2023 05:55
@dongoc
Copy link
Contributor Author

dongoc commented Nov 3, 2023

release-canary

Copy link

github-actions bot commented Nov 3, 2023

v13.9.1-pr-2973.9 has been published!

@dongoc dongoc merged commit 90d575d into main Nov 6, 2023
11 checks passed
@dongoc dongoc deleted the fix/sender branch November 6, 2023 00:32
@dongoc dongoc modified the milestones: v13.9.1, v13.10.0 Nov 6, 2023
@dongoc dongoc mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants