Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chat] beforeSentMessages 기본값 불필요하므로 제거 #2975

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[chat] beforeSentMessages 기본값 불필요하므로 제거 #2975

merged 1 commit into from
Oct 31, 2023

Conversation

choisohyun
Copy link
Contributor

@choisohyun choisohyun commented Oct 31, 2023 •
edited
Loading

PR 설명

변경 내역

  • reducer에서 beforeSentMessages의 기본 상태값이 빈 배열이기 때문에 기본값 불필요하여 제거합니다.

체크리스트

스크린샷 & URL

@choisohyun
Copy link
Contributor Author

release-canary

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99c2c38) 12.17% compared to head (d48aacd) 12.17%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2975   +/-   ##
=======================================
  Coverage   12.17%   12.17%           
=======================================
  Files         687      687           
  Lines       36213    36213           
  Branches     8943     8943           
=======================================
  Hits         4410     4410           
  Misses      31796    31796           
  Partials        7        7
Files Coverage Δ
packages/chat/src/chat/chat.tsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

v13.8.2-pr-2975.4 has been published!

@choisohyun choisohyun self-assigned this Oct 31, 2023
@choisohyun choisohyun added this to the v13.8.2 milestone Oct 31, 2023
@choisohyun choisohyun marked this pull request as ready for review October 31, 2023 06:10
@choisohyun choisohyun requested a review from a team as a code owner October 31, 2023 06:10
@choisohyun choisohyun requested review from drakang4, jaehyeon48 and YWTechIT and removed request for a team October 31, 2023 06:10
@github-actions github-actions bot added the chat label Oct 31, 2023
@choisohyun choisohyun changed the title refactor: beforeSentMessages 기본값 불필요하므로 제거 [chat] beforeSentMessages 기본값 불필요하므로 제거 Oct 31, 2023
@choisohyun choisohyun mentioned this pull request Oct 31, 2023
Merged
@choisohyun choisohyun merged commit 1cd4524 into main Oct 31, 2023
12 checks passed
@choisohyun choisohyun deleted the refactor/chat-default-value branch October 31, 2023 07:09
@seulgiyoon seulgiyoon modified the milestones: v13.8.2, v13.9.0 Oct 31, 2023
@seulgiyoon seulgiyoon mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dia-triple dia-triple dia-triple approved these changes

@seulgiyoon seulgiyoon seulgiyoon approved these changes

@drakang4 drakang4 Awaiting requested review from drakang4 drakang4 is a code owner automatically assigned from titicacadev/frontend

@jaehyeon48 jaehyeon48 Awaiting requested review from jaehyeon48 jaehyeon48 is a code owner automatically assigned from titicacadev/frontend

@YWTechIT YWTechIT Awaiting requested review from YWTechIT YWTechIT is a code owner automatically assigned from titicacadev/frontend

Assignees

@choisohyun choisohyun

Labels
chat
Projects
None yet
Milestone
v13.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@choisohyun @seulgiyoon @dia-triple