Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KLZT-766 영상기본음소거 #3503

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

paulbkim01
Copy link
Contributor

@paulbkim01 paulbkim01 commented Dec 19, 2024

PR 설명

컨텐츠 어드민 (POI, Article)에서 영상 업로드시 "videoInitiallyMuted"라는 상태값을 추가하는 변경을 작업하는 중입니다.
각 도메인의 payload의 이미지들이 이제 영상일 경우 선택적으로 "videoInitiallyMuted"라는 플래그를 갖게 되며, 만약 이 플래그가
True일 경우 영상재생시 기본 음소거 상태가 되어야합니다.

요구사항 링크

필드가 옵셔널이기 때문에, API의 동작여부와 별개로 영향도가 존재하지 않습니다.

변경 내역

tds-widget의 Media Component에서 initiallyMuted 플래그가 있을 시 영상을 재생해도 기본 음소거가 되어야합니다.
tds-widget은 리뷰/트리플도큐먼트에서 모두 사용하는 것으로 확인되었습니다.

현재 기준으로 이 음소거는 유저의 행동에 의해 해제될 수 있습니다.

@paulbkim01 paulbkim01 requested a review from a team as a code owner December 19, 2024 04:12
@paulbkim01 paulbkim01 requested review from dongoc, gigibean, YWTechIT, guswl98 and seulgiyoon and removed request for a team December 19, 2024 04:12
@paulbkim01 paulbkim01 force-pushed the KLZT-766-영상기본음소거 branch from cb7d78d to c680a3f Compare December 19, 2024 04:13
@paulbkim01 paulbkim01 changed the title Klzt 766 영상기본음소거 KLZT-766 영상기본음소거 Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.47%. Comparing base (0a63dd8) to head (9cc82d3).
Report is 183 commits behind head on v13.

Files with missing lines Patch % Lines
packages/triple-media/src/triple-media.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              v13    #3503      +/-   ##
==========================================
+ Coverage   10.39%   10.47%   +0.08%     
==========================================
  Files         705      705              
  Lines       33322    27157    -6165     
  Branches     9043     7390    -1653     
==========================================
- Hits         3465     2846     -619     
+ Misses      29850    24291    -5559     
- Partials        7       20      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seulgiyoon
Copy link
Contributor

요거 14에 적용하시나요? 13 버전에 적용해서 바로 적용되어야 하는 건 아닌가요?

@paulbkim01
Copy link
Contributor Author

요거 14에 적용하시나요? 13 버전에 적용해서 바로 적용되어야 하는 건 아닌가요?

아 생각해보니, v13 브랜치에서 체리픽을 해야죠?

@seulgiyoon
Copy link
Contributor

요거 14에 적용하시나요? 13 버전에 적용해서 바로 적용되어야 하는 건 아닌가요?

아 생각해보니, v13 브랜치에서 체리픽을 해야죠?

넵넵. https://github.com/titicacadev/triple-frontend/tree/v13 요 브랜치를 베이스로 작업하신 후 버전업해서 릴리즈해 사용하고, 이후에 main 브랜치에 변경분을 반영해야해요!

@paulbkim01 paulbkim01 changed the base branch from main to v13 December 19, 2024 05:18
@paulbkim01 paulbkim01 force-pushed the KLZT-766-영상기본음소거 branch from c680a3f to ab7729d Compare December 19, 2024 05:20
@paulbkim01 paulbkim01 force-pushed the KLZT-766-영상기본음소거 branch from ab7729d to 9cc82d3 Compare December 19, 2024 05:20
@paulbkim01
Copy link
Contributor Author

release-canary

Copy link

v13.23.2-pr-3503.0 has been published!

@paulbkim01 paulbkim01 merged commit 1f6b67e into v13 Dec 19, 2024
12 of 15 checks passed
@paulbkim01 paulbkim01 deleted the KLZT-766-영상기본음소거 branch December 19, 2024 05:56
@paulbkim01 paulbkim01 mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants