Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[triple-email-template] default 링크 스타일을 추가하고, 스크롤 포커싱 이슈를 해결합니다. #3517

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Dec 24, 2024

PR 설명

컨텐츠 어드민 개선사항으로 다음과 같은 작업을 진행합니다.

  • default 링크 스타일을 추가합니다. (관련 스레드)
    • triple-document의 default 링크 스타일을 triple-email-document에도 추가합니다. 스타일 외 기능은 동일합니다.
  • 스크롤 포커싱 이슈를 해결합니다.
    • triple-email-document의 element로 id값이 주입되지 않는 문제를 해결합니다.

@dongoc dongoc added this to the 13.39.0 milestone Dec 24, 2024
@dongoc dongoc self-assigned this Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 10.17%. Comparing base (365d9ee) to head (523db76).
Report is 7 commits behind head on v13.

Files with missing lines Patch % Lines
...kages/triple-email-document/src/elements/links.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              v13    #3517      +/-   ##
==========================================
- Coverage   10.17%   10.17%   -0.01%     
==========================================
  Files         718      718              
  Lines       28027    28030       +3     
  Branches     7633     7633              
==========================================
  Hits         2852     2852              
- Misses      25155    25158       +3     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc
Copy link
Contributor Author

dongoc commented Dec 24, 2024

release-canary

Copy link

v13.38.1-pr-3517.0 has been published!

@dongoc
Copy link
Contributor Author

dongoc commented Dec 26, 2024

release-canary

Copy link

v13.38.1-pr-3517.2 has been published!

@dongoc dongoc force-pushed the feature/email-default-link branch from 5c9f7cf to dadb3c1 Compare December 26, 2024 06:21
@dongoc
Copy link
Contributor Author

dongoc commented Dec 26, 2024

release-canary

Copy link

v13.38.1-pr-3517.2 has been published!

@dongoc
Copy link
Contributor Author

dongoc commented Dec 26, 2024

release-canary

Copy link

v13.38.1-pr-3517.3 has been published!

@dongoc dongoc changed the title [triple-email-template] default 링크 스타일을 추가합니다. [triple-email-template] default 링크 스타일을 추가하고, 스크롤 포커싱 이슈를 해결합니다. Dec 27, 2024
@dongoc dongoc marked this pull request as ready for review December 30, 2024 02:03
@dongoc dongoc requested a review from a team as a code owner December 30, 2024 02:03
@dongoc dongoc requested review from inbeom, guswl98, torres-triple and a team and removed request for a team December 30, 2024 02:03
Copy link

@audrey-yoon audrey-yoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 다른 triple email document에는 id를 추가하지 않아도 괜찮을까요?
(아마 이 이슈에서는 heading을 제외하고 id를 사용하는 부분이 없지 싶어 보이기는 하네요...🤔)

@dongoc
Copy link
Contributor Author

dongoc commented Dec 30, 2024

혹시 다른 triple email document에는 id를 추가하지 않아도 괜찮을까요?
(아마 이 이슈에서는 heading을 제외하고 id를 사용하는 부분이 없지 싶어 보이기는 하네요...🤔)

id 주입은 어드민에서만 사용하고 있고, heading을 제외한 나머지 elements에는 id를 주입하지 않아서 지금은 heading에만 넣어두었습니다.
추후에 기능이 더 확대된다면 그 때 모든 element에 wrapper로 props를 넣어주는 걸 생각하고 있습니다.

@dongoc
Copy link
Contributor Author

dongoc commented Jan 2, 2025

🙇‍♂️

@dongoc dongoc merged commit 7f96b1b into v13 Jan 2, 2025
12 checks passed
@dongoc dongoc deleted the feature/email-default-link branch January 2, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants