Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script currently circularizes every 2D convolution in the model indiscriminately #4

Open
tjm35 opened this issue Nov 18, 2022 · 0 comments
Assignees

Comments

@tjm35
Copy link
Owner

tjm35 commented Nov 18, 2022

As title; currently our approach to tiling is to circularize every 2D convolution in the model regardless of size or purpose, on the assumption that every 2D structure represents image data in a spatial layout.

This does generally seem to work fine, but it is possible that some distortion is being caused by circularizing convolutions that are operating on other kinds of data. Resolving this issue would require going through the SD model, understanding the purpose of each use of Conv2D, then modifying this script so that it only circularizes convolutions that genuinely represent image-space data.

@tjm35 tjm35 self-assigned this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant