Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if NMBR arrives after NAME, the callerid notification will miss the phone number #3

Open
monehsieh opened this issue May 18, 2023 · 0 comments · May be fixed by #4
Open

if NMBR arrives after NAME, the callerid notification will miss the phone number #3

monehsieh opened this issue May 18, 2023 · 0 comments · May be fixed by #4

Comments

@monehsieh
Copy link

if NMBR arrives after NAME, the callerid notification will miss the phone number. It'd be safer if the code can wait till all name, time and NUMBER arrvie before notifying.
raineth added a commit to raineth/phone_modem that referenced this issue May 11, 2024
@raineth
Add support for more types of modems.
5fcbf57 
- After each line of caller ID data, check whether both a name and
  number field have been received and only then advance to
  STATE_CALLERID.  This allows proper functionality regardless of the
  order in which the caller ID data is sent by the modem.  (closes tkdrob#3)
- Accept DDN_NMBR as an alias for NMBR in caller ID data.  (closes tkdrob#2)
@raineth raineth linked a pull request May 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for more types of modems. raineth/phone_modem
1 participant
@monehsieh