Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read eeprom calibration values #10

Closed
tknopp opened this issue Oct 23, 2017 · 1 comment · Fixed by #32
Closed

Read eeprom calibration values #10

tknopp opened this issue Oct 23, 2017 · 1 comment · Fixed by #32
Assignees

Comments

@tknopp
Copy link
Owner

tknopp commented Oct 23, 2017

from #7

We should use the eeprom stuff that is implemented in the regular RP API:
https://github.com/RedPitaya/RedPitaya/blob/1dfabae67968cc76548e461c7d123a284d3df725/api/src/calib.c
If that is done the DAC API should use voltage.

In particular I want the "setAmplitude" function to work in Voltage mode. The ADC values should not be converted to float on the RP but rather on the client side. Thus we need to make the scaling/offset values accessible from the client.

@jonschumacher
Copy link
Collaborator

Should we also use the EEPROM values in the ADC within readPeriods() and readFrames() respectively or should this be left in MPIMeasurements and we just save the respective calibration tuple with scale and offset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants