Re-evaluate cryptography library usage #1313
Labels
⚙️ backend
dependencies
Pull requests that update a dependency file
📈 enhancement
New feature or request
@lsloan and @jonespm, I'd like some feedback here. I asked @lsloan to remove
jwtcrypto
in #1101, and I think he took the initiative to see if he could also removepycryptodome
-- which worked at the time I guess? However, when I removedpyOpenSSL
, it seems to have broken thecreatekeys
management command (and maybe alsogetjwk
). Addingpycryptodome
back here seems to have fixed the problem.I know the cryptographic space in Python is a little strange, but it would be nice for maintenance purposes if there was a clearer tie between library marked as a requirement, and library being imported. If
pyOpenSSL
was being used for cryptography (through some indirect way toCrypto
), we should make note of that inrequirements.txt
. It also seems likepyOpenSSL
is unmaintained, and the recommendation is to replace it withcryptography
. Maybe we ought to replacepycryptodome
withcryptography
; that would probably require some more research (see https://cryptography.io/en/latest/faq/#why-use-cryptography).What do you think would be the appropriate course of action at this point?
Originally posted by @ssciolla in #1300 (comment)
The text was updated successfully, but these errors were encountered: