Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate cryptography library usage #1313

Open
ssciolla opened this issue Sep 9, 2021 · 0 comments
Open

Re-evaluate cryptography library usage #1313

ssciolla opened this issue Sep 9, 2021 · 0 comments
Labels
⚙️ backend dependencies Pull requests that update a dependency file 📈 enhancement New feature or request

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Sep 9, 2021

@lsloan and @jonespm, I'd like some feedback here. I asked @lsloan to remove jwtcrypto in #1101, and I think he took the initiative to see if he could also remove pycryptodome -- which worked at the time I guess? However, when I removed pyOpenSSL, it seems to have broken the createkeys management command (and maybe also getjwk). Adding pycryptodome back here seems to have fixed the problem.

I know the cryptographic space in Python is a little strange, but it would be nice for maintenance purposes if there was a clearer tie between library marked as a requirement, and library being imported. If pyOpenSSL was being used for cryptography (through some indirect way to Crypto), we should make note of that in requirements.txt. It also seems like pyOpenSSL is unmaintained, and the recommendation is to replace it with cryptography. Maybe we ought to replace pycryptodome with cryptography; that would probably require some more research (see https://cryptography.io/en/latest/faq/#why-use-cryptography).

What do you think would be the appropriate course of action at this point?

Originally posted by @ssciolla in #1300 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ backend dependencies Pull requests that update a dependency file 📈 enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant