Rendered output displays "See also:" line twice

[kbdharun]

Expected behavior

Continuing tldr-pages/tldr#5190 (comment) (cc @sbrl).

The rendered output of pages should be displayed as is without a redundant "See also:" entry below the pages.

Actual behavior

Currently, the rendered output of pages displays the "See also:" line twice and in pages using a description like encfs it might be useful but still redundant.

Also in pages where we add it to an existing line in those cases this additional rendering doesn't take place:

What do you guys think, should we remove it? (IMO removing it will make the rendering consistent with other clients which doesn't do this)

If we decide to go with it, removing the below lines would resolve this issue:

tldr-node-client/lib/render.js

Lines 48 to 52 in 3e65c25

	if (page.seeAlso && page.seeAlso.length > 0) {
	output.push('');
	output.push('See also: ' + page.seeAlso.join(', '));
	output.push('');
	}

Environment

• Operating system - Linux (Ubuntu LTS 22.04, Fedora Workstation 39), Windows (11)
• Node.js version (node --version): v20.9.0
• tldr-node-client version (tldr --version): 3.4.0

[sbrl]

Where is the bottom See also pulled from? If it's taken from the page content, I don't particularly see a reason to keep it.

I wonder what the reasoning was behind adding it in the first place was?

[kbdharun]

Where is the bottom See also pulled from? If it's taken from the page content, I don't particularly see a reason to keep it.

Yep, it's taken from the page content.

I wonder what the reasoning was behind adding it in the first place was?

Same here, it was implemented in #81 and it seems to be discussed here in tldr-pages/tldr#481.

[owenvoke]

I agree that it doesn't really make much sense, as it's usually already within the page. 👍🏻

[sbrl]

Ahh I see. This feature parses

(see `blah`)

lines in descriptions, but fails to account for if they are mentioned in the See also description line.

In this case, I would consider this a bug in that feature.