-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up tlsn-wasm build #553
Conversation
7c01463
to
25fcca9
Compare
48231f8
to
b35df6f
Compare
Shouldn't this be something that occurs on release and not part of CI? Should this be taken care of in |
Doing it here has the advantage that a build is available for every code change. This would also allow us to easily add it as an artifact to releases. The tlsn-js job can then simply fetch it. The automation could look something like this:
|
@0xtsukino thoughts on this? |
@heeckhau and I discussed after his comment and we agreed at at least for the near future it would be easier for me to simply run the build locally, test them via
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #553 +/- ##
=======================================
Coverage 55.43% 55.43%
=======================================
Files 193 193
Lines 20853 20853
=======================================
Hits 11560 11560
Misses 9293 9293 ☔ View full report in Codecov by Sentry. |
No description provided.