Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tlsn-wasm build #553

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Clean up tlsn-wasm build #553

merged 10 commits into from
Dec 6, 2024

Conversation

heeckhau
Copy link
Member

@heeckhau heeckhau commented Aug 1, 2024

No description provided.

@heeckhau heeckhau force-pushed the wasm_build branch 2 times, most recently from 7c01463 to 25fcca9 Compare August 1, 2024 13:17
@heeckhau heeckhau requested review from sinui0 and 0xtsukino August 1, 2024 13:19
@heeckhau heeckhau force-pushed the wasm_build branch 2 times, most recently from 48231f8 to b35df6f Compare August 2, 2024 14:18
@sinui0
Copy link
Member

sinui0 commented Aug 5, 2024

Shouldn't this be something that occurs on release and not part of CI?

Should this be taken care of in tlsn-js instead?

@heeckhau
Copy link
Member Author

Shouldn't this be something that occurs on release and not part of CI?

Should this be taken care of in tlsn-js instead?

Doing it here has the advantage that a build is available for every code change.

This would also allow us to easily add it as an artifact to releases. The tlsn-js job can then simply fetch it.

The automation could look something like this:

name: Create Draft Release

on:
  push:
    tags:
      - 'v*'  # Triggers on version tags like v1.0.0

jobs:
  release:
    runs-on: ubuntu-latest

    steps:
    - name: Download build artifacts
      uses: actions/download-artifact@v4
      with:
        name: tlsn-wasm-pkg

    - uses: ncipollo/release-action@v1
      with:
        artifacts: "tlsn-wasm-pkg.zip"
        name: ${{ github.ref }}
        draft: true
        prerelease: true
        generateReleaseNotes: true

@sinui0
Copy link
Member

sinui0 commented Sep 19, 2024

@0xtsukino thoughts on this?

@0xtsukino
Copy link
Collaborator

@0xtsukino thoughts on this?

@heeckhau and I discussed after his comment and we agreed at at least for the near future it would be easier for me to simply run the build locally, test them via npm link, and then publish to npm as tlsn-wasm on my machine.

tlsn-js will then just have a dependency on tlsn-wasm. tlsn-wasm will see little to no changes after each release, and tlsn-js might see more integration related bug fixes, and is purposely built for direct integration into tlsn-extension-esque architecture.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.43%. Comparing base (d974fb7) to head (17515eb).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #553   +/-   ##
=======================================
  Coverage   55.43%   55.43%           
=======================================
  Files         193      193           
  Lines       20853    20853           
=======================================
  Hits        11560    11560           
  Misses       9293     9293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heeckhau heeckhau changed the title ci: add job for building and uploading tlsn-wasm build result Clean up tlsn-wasm build Nov 26, 2024
crates/wasm/Cargo.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@heeckhau heeckhau linked an issue Dec 3, 2024 that may be closed by this pull request
@heeckhau heeckhau merged commit 85e0f5b into dev Dec 6, 2024
8 checks passed
@heeckhau heeckhau deleted the wasm_build branch December 6, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve README of tlsn-wasm
3 participants