Fix/core validation #648
Open
Fix/core validation #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #648 +/- ##
==========================================
+ Coverage 54.35% 54.43% +0.07%
==========================================
Files 192 192
Lines 20474 20530 +56
==========================================
+ Hits 11129 11175 +46
- Misses 9345 9355 +10 ☔ View full report in Codecov by Sentry. |
yuroitaki
approved these changes
Dec 12, 2024
| /// | ||
| /// DO NOT use bit encodings which have less than 50 uniformly random bits, | ||
| /// since the SSP < 40 bits is widely considered inadequate. | ||
| const MAX_HEIGHT: usize = 10; |
There was a problem hiding this comment.
is there any reason why 10 is chosen?
There was a problem hiding this comment.
No specific reason other than we want to achieve SSP=40 and don't want to mandate that encodings are unnecessarily large. It seemes reasonable that there won't be > 1024 commitments. Although, now I'm realizing that with our json commit-to-everything strategy 1024 may be insufficient.
Let's tag @sinui0 to double check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation to some of the core types.
Also renames
tree_lentoleaf_countsince "tree length" is too ambiguous.