Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add core transcript unit tests #649

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

yuroitaki
Copy link
Member

This adds the remaining unit tests that are missing from #608. Some minor refactoring to create reusable test fixtures are included too.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 99.46667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.43%. Comparing base (faab999) to head (bbb6c93).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/core/src/fixtures.rs 97.64% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #649      +/-   ##
==========================================
+ Coverage   54.48%   55.43%   +0.94%     
==========================================
  Files         193      193              
  Lines       20618    20842     +224     
==========================================
+ Hits        11234    11553     +319     
+ Misses       9384     9289      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, pls fix the formating as per my comment and feel free to merge.

crates/core/src/transcript.rs Outdated Show resolved Hide resolved
@yuroitaki yuroitaki merged commit c10c915 into dev Nov 4, 2024
8 checks passed
@yuroitaki yuroitaki deleted the chore/core-transcript-unit-test branch November 28, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants