Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criticar Bug, DeleteAsync doesn't work with predicates #320

Open
juliotec opened this issue Jun 29, 2023 · 2 comments
Open

Criticar Bug, DeleteAsync doesn't work with predicates #320

juliotec opened this issue Jun 29, 2023 · 2 comments

Comments

@juliotec
Copy link

juliotec commented Jun 29, 2023

Please fix this ASAP, DeleteAsync doesn't work with any predicates and i will explain why

Right now your code is like this

image

both methods always call to

image

never go to

image

The Fix is very easy, just ad this

image

in this way the "runtime" must know which method use it

Why the issue is happening? simple

image

Both definitions have conflicts because one use generic T in the second parmeter and the other use object in the second parameter, if you doesn't expecify the generic T, "runtime" assume the generic method and never go to the object method, so if you especify the generic T, now "runtime" must know wich value is T.

please add the generic T in this method like this

image

I doens't know why nobody show this critical bug, DeleteAsync with predicates is usless

@juliotec
Copy link
Author

juliotec commented Jun 29, 2023

I'm trying to create a Pull Request but I can't, please fix and update the nuget package

@spkirby
Copy link

spkirby commented Jul 14, 2023

I'm having this exact same problem. I'm using a custom default mapper so calling DeleteAsync() without the generic parameter is causing Dapper to try and load CustomAutoClassMapper<Object>. Understandably, this doesn't work so well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants