Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the status of an uploaded document with errors and see about adding transactions #17

Open
tmtsoftwareadmin opened this issue Dec 14, 2015 · 2 comments

Comments

@tmtsoftwareadmin
Copy link

Database updates should probably be done with transactions. Not sure what is being done currently. MongoDB seems to support transactions and 2 phase commit.

We also need to clarify the use/status of the uploaded set of documents that have not been published.

@abrighton
Copy link
Contributor

Transactions are difficult (or impossible) to implement in MongoDB, especially since we are using multiple collections. The current icd version now validates all ICD files before ingesting any into the database. If the files are all valid, there should not normally be any database errors.

@tmtsoftwareadmin
Copy link
Author

I don't think we should close this. It's a good idea to support transactions, maybe we need a different solution. I prefer that we leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants