Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup reusable channel/stub for each encountered node address #7

Open
tnkhanh opened this issue Oct 19, 2020 · 1 comment
Open

Setup reusable channel/stub for each encountered node address #7

tnkhanh opened this issue Oct 19, 2020 · 1 comment

Comments

@tnkhanh
Copy link
Owner

tnkhanh commented Oct 19, 2020

Channels might be expensive to create. Maybe a map<Address, Channel/Stub> can be used to reuse them.
Otherwise, we can create a new channel+stub for most RPCs.
@tnkhanh
Copy link
Owner Author

tnkhanh commented Oct 22, 2020

If a lot of Channels are saved overtime, they may break the program (maybe around 1M channels?).
For now, for simplicity, a new channel + stub is created for each RPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tnkhanh