Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIArms open bolt weapons are incompatible with ace cookoff #174

Open
BorderKeeper opened this issue Feb 26, 2022 · 1 comment · May be fixed by #176
Open

NIArms open bolt weapons are incompatible with ace cookoff #174

BorderKeeper opened this issue Feb 26, 2022 · 1 comment · May be fixed by #176

Comments

@BorderKeeper
Copy link

BorderKeeper commented Feb 26, 2022

Open bolt weapons in NIArms are wrongly set as closed bolt causing them to cook off in ACE even though they should not

@Drofseh
Copy link

Drofseh commented Feb 27, 2022

The root cause of this is that many (all?) NI Arms machine guns use Rifle_Base_F as their parent class, while vanilla machine guns and many other mod machine guns use Rifle_Long_Base_F for their parent class.

In ACE3's Overheating addon Rifle_Long_Base_F are assumed to be open bolt be default, while Rifle_Base_F are assumed to be closed bolt by default, through Rifle.
https://github.com/acemod/ACE3/blob/master/addons/overheating/CfgWeapons.hpp

The best fix imo, would be to change NI Arms to follow the same inheritence as is typical for vanilla, and use Rifle_Long_Base_F as the parent for all machine gun classes, leaving Rifle_Base_F for rifles.

Alternatively, each weapon base class can be set individually to open or closed bolt with ace_overheating_closedBolt,
https://ace3mod.com/wiki/framework/overheating-framework.html#14-cook-off

@Whigital Whigital linked a pull request Nov 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants