Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt C binary in source #883

Closed
benthetechguy opened this issue Jun 7, 2022 · 3 comments
Closed

Prebuilt C binary in source #883

benthetechguy opened this issue Jun 7, 2022 · 3 comments

Comments

@benthetechguy
Copy link
Contributor

Instead of having an x86_64 Linux binary hanging around in your source, maybe it would be better to compile it at build time. There are other architectures out there, you know.
It would be preferable if there were no C code in this Python module at all, because the built package could be architecture independent.

@anarcat
Copy link
Contributor

anarcat commented Jun 7, 2022

agreed. this seems to converge towards #790 as well: there should be just one layout module, and I personally think it should be the python version, not the C stub.

(or, if it's a C stub, it should be a pyx stub. :)

@tobi-wan-kenobi
Copy link
Owner

I fully agree on both counts :)

@tobi-wan-kenobi
Copy link
Owner

Just removed everything precompiled and fall back to the python xkb module.

Now, I am waiting for the bug reports about broken layout module coming in :)

Thanks for your valuable input everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants