Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent CPAN release of Type::Tiny appears to break MooX::Press #4

Open
jkeenan opened this issue Apr 9, 2023 · 2 comments
Open

Recent CPAN release of Type::Tiny appears to break MooX::Press #4

jkeenan opened this issue Apr 9, 2023 · 2 comments

Comments

@jkeenan
Copy link

jkeenan commented Apr 9, 2023

It was recently reported to the Perl 5 issue tracker that CPAN module MooX::Press was no longer passing its tests when built against Perl 5 blead. Discussion in the bug ticket eventually led us to believe that the test failures were not due to a change in the Perl 5 core distribution. Rather, a recent release of Type-Tiny, which is a prerequisite for MooX-Press, was the likely trigger for the breakage.

I have not yet studied Type-Tiny, so I'm not making any definitive statement as yet. But I do urge you to read that bug ticket and review CPANtesters reports for MooX-Press.

@cjg-cguevara @andk

@jkeenan
Copy link
Author

jkeenan commented Apr 10, 2023

Debugging points to the following commit as the likely cause of downstream breakage in MooX::Press:

commit 99c857df4a56194a3142bb00af4d5a8b2d23148d
Author:     Toby Inkster <[email protected]>
AuthorDate: Sat Apr 1 18:01:26 2023 +0100
Commit:     Toby Inkster <[email protected]>
CommitDate: Sat Apr 1 18:01:26 2023 +0100

    Inherit exception_class from parent type when possible

Can you investigate?

Thank you very much.
Jim Keenan

@tobyink tobyink transferred this issue from tobyink/p5-type-tiny Apr 11, 2023
@tobyink
Copy link
Owner

tobyink commented Apr 11, 2023

MooX::Press is doing something like:

my $class   = "Animal::Dog";
my $toolkit = "Moo";
$toolkit->import::into( $class );

Moo is checking caller and for some reason caller is responding with "::Animal::Dog" as the caller package. I have no idea why. import::into is definitely being called with "Animal::Dog" its parameter, and no leading "::".

@haarg?

The one thing I've noticed is that I do have *{'Animal::'} = *{'::Animal::'} in %::. Should that affect how caller reports a package name?

@tobyink tobyink changed the title Recent CPAN release appears to break MooX::Press Recent CPAN release of Type::Tiny appears to break MooX::Press Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants