Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upon winning a private that comes with a director share, the player doesn't receive the shares until after parring #5057

Open
thepackrat opened this issue Apr 14, 2021 · 2 comments
Labels
18Chesapeake 18CO 18MEX 1828.Games 1830 1849 1870 entity display Bugs/Enhancements relating to entity (player, corp, company) display minor bug A minor bug that doesn't impact game play (erronous logging)

Comments

@thepackrat
Copy link
Collaborator

thepackrat commented Apr 14, 2021

Example for 1828.Games, but applies to any of these games:

After buying any B&O (any one of the privates that grants 30% in a company), the company shows up at the end of the auction asking you to set the par price. At that time, the company shows 1 share owned by you, and "50% to float".

It should show 3 shares owned by you (because you have bought the B&O) and 30% to float, so epople can select a par that lets them buy 3 shares to float, to avoid giving people a feeling of despair when setting the par price.

@benjaminxscott benjaminxscott added 1828.Games entity display Bugs/Enhancements relating to entity (player, corp, company) display and removed needs triage labels Apr 14, 2021
@crericha
Copy link
Collaborator

This is true for all games that have a private that comes with a director share.

@crericha crericha changed the title 1828 shows incorrect ownership/float numbers when parring B&Os Upon winning a private that comes with a director share, the player doesn't receive the shares until after parring Apr 14, 2021
@crericha crericha added the 18MEX label Apr 14, 2021
@benjaminxscott
Copy link
Contributor

benjaminxscott commented Apr 15, 2021

I tried moving buy_shares() out of the step into the base class, but there's some other code that is coupled to that, like setting corp.ipoed etc

Note that overloaded implementations such as 18CO, 1870, et. al will also need updated

@scottredracecar scottredracecar added the minor bug A minor bug that doesn't impact game play (erronous logging) label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18Chesapeake 18CO 18MEX 1828.Games 1830 1849 1870 entity display Bugs/Enhancements relating to entity (player, corp, company) display minor bug A minor bug that doesn't impact game play (erronous logging)
Projects
None yet
Development

No branches or pull requests

4 participants